fix GLR × RHW crosslinks#517
Merged
Merged
Conversation
replaced by metarules
Removing these vastly improves L2 RHW × GLR stability.
The handwritten GLR code frequently switches between 1,0 and 3,0 orientations for orthogonal GLR, so this change may aid compatibility with metarules.
for better compatibility with old handwritten GLR code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new
GlrRuleGeneratorto generate crosslinks for GLR with RHW and NWM. The GLR-side crosslinks have gone missing since #493.Any RUL2 code involving L2 RHW × L2 Lightrail is removed, as those crossings don't really exist and removing them improves stability immensely for L2 RHW × GLR.
Nothing more than the crosslinks are added as part of this PR. (In the long run, more of the GLR RUL2 code could be converted to metarules. The old GLR code has a few issues, as it frequently reverses the direction of orthogonal GLR tiles, as the code is written more like a directed/asymmetrical network such as MIS than a symmetrical network.)